Comments on: The New Definitive SPSite/SPWeb Disposal Article

By: Keith Dahlby

Keith Dahlby — Sat, 31 Oct 2009 02:17:21 +0000

Great questions, Andy. You’re fine to use SPContext.Current in a custom web service because ASMX still participate in the ASP.NET request lifecycle. SharePoint registers an IHttpModule (Microsoft.SharePoint.ApplicationRuntime.SPRequestModule) which takes responsibility for cleaning up the context objects.

The most efficient way to iterate over a large tree of SPWeb objects is to use SPSite.AllWebs, which flattens the heirarchy and creates no parent-child web dependencies (unless you use ParentWeb or a member that requires it). If you have to navigate as a tree structure, you will need to leaving your chain of parent webs open. As you’re enumerating through a web’s child SPWebCollection, internally each successive web is created through the internal SPWeb+SPWebCollectionProvider class, whose OpenWeb() method depends on the parent web.

Hope this helps ~
Keith

By: Andy

Andy — Thu, 29 Oct 2009 17:08:14 +0000

What about a custom web service (.ASMX) placed in the Layouts folder, how does sharepoint know to automatically dispose of SPContext.Current.Web when the whole request is handled by code you wrote? (i.e does not extend one of the SharePoint classes) So the question is, where are these context objects disposed? I think they are not disposed.

Also, is there a suggested pattern for itterating through large tree’s of SPWeb objects without having SPWeb * depthOfTree undisposed at the same time? So in otherwords itterate a tree of SPWeb Objects but only having one undisposed SPWeb at a time?

By: SharePoint Code Optimization « Emad’s Weblog

SharePoint Code Optimization « Emad’s Weblog — Fri, 27 Feb 2009 21:15:42 +0000

[...] http://solutionizing.net/2008/12/06/the-new-definitive-spsitespweb-disposal-article/ [...]

By: Keith Dahlby

Keith Dahlby — Fri, 02 Jan 2009 09:39:19 +0000

I'll try to keep this post updated, but this article on the SharePoint Dev Wiki should have the community's latest thoughts on disposal.

By: Disposing list’s SPSite/SPWeb without ParentWeb « Solutionizing .NET

Disposing list’s SPSite/SPWeb without ParentWeb « Solutionizing .NET — Thu, 11 Dec 2008 02:31:56 +0000

[...] Disposing list’s SPSite/SPWeb without ParentWeb June 15, 2008 — Keith Dahlby Update 12/10/2008: Don’t use this technique; use the guidance here instead: The New Definitive SPSite/SPWeb Disposal Article [...]

By: Keith Dahlby

Keith Dahlby — Mon, 08 Dec 2008 16:44:12 +0000

@Rick ~ Agreed and done. I can’t find a definitive post on this online, but according to Reflector the Web property setter is internal and only set in SPWeb.DoProvisioningCallback to “this”, which should be cleaned up by its owner. Good catch!

I also added SPControl.GetCurrentSite() and Web().

@Peter ~ Clarity at last? We can only hope…

By: Peter Seale

Peter Seale — Mon, 08 Dec 2008 16:27:49 +0000

Keith, thanks for writing this article, it helped me out for sure.

By: Rick

Rick — Mon, 08 Dec 2008 16:11:32 +0000

Hi,

I think you should add this one to the “Do not dispose” list as well
SPWebProvisioningProperties.Web

Cheers
Rick

By: Links (12/7/2008) « Steve Pietrek - Everything SharePoint

Links (12/7/2008) « Steve Pietrek - Everything SharePoint — Sun, 07 Dec 2008 22:58:00 +0000

[...] **** The New Definitive SPSite/SPWeb Disposal Article [...]

By: Keith Dahlby

Keith Dahlby — Sun, 07 Dec 2008 07:16:10 +0000

Absolutely – the more eyes, the better the eventual consensus.